Merged
Conversation
kasiafi
force-pushed
the
MinorOperatorCleanup
branch
2 times, most recently
from
9d60569 to
7891510
Compare
martint
reviewed
Oct 26, 2020
presto-main/src/main/java/io/prestosql/operator/SimplePagesIndexInterChannelComparator.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/io/prestosql/operator/SimplePagesIndexInterChannelComparator.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/io/prestosql/operator/WindowOperator.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/io/prestosql/operator/PagesIndex.java
Outdated
Show resolved
Hide resolved
kasiafi
force-pushed
the
MinorOperatorCleanup
branch
from
7891510 to
b9979c3
Compare
v-jizhang
added a commit
to v-jizhang/presto
that referenced
this pull request
Oct 26, 2021
Cherry-pick of trinodb/trino#5639 Co-authored-by: kasiafi <30203062+kasiafi@users.noreply.github.com>
v-jizhang
added a commit
to v-jizhang/presto
that referenced
this pull request
Oct 29, 2021
Cherry-pick of trinodb/trino#5639 Co-authored-by: kasiafi <30203062+kasiafi@users.noreply.github.com>
v-jizhang
added a commit
to v-jizhang/presto
that referenced
this pull request
Jan 2, 2023
Cherry-pick of trinodb/trino#5639 Co-authored-by: kasiafi <30203062+kasiafi@users.noreply.github.com>
feilong-liu
added a commit
to feilong-liu/presto
that referenced
this pull request
Feb 16, 2023
Cherry-pick of trinodb/trino#5639 Co-authored-by: Jinlin Zhang <z_jinlin@yahoo.com> Co-authored-by: kasiafi <30203062+kasiafi@users.noreply.github.com>
feilong-liu
added a commit
to prestodb/presto
that referenced
this pull request
Feb 17, 2023
Cherry-pick of trinodb/trino#5639 Co-authored-by: Jinlin Zhang <z_jinlin@yahoo.com> Co-authored-by: kasiafi <30203062+kasiafi@users.noreply.github.com>
wanglinsong
pushed a commit
to prestodb/presto
that referenced
this pull request
Feb 21, 2023
Cherry-pick of trinodb/trino#5639 Co-authored-by: Jinlin Zhang <z_jinlin@yahoo.com> Co-authored-by: kasiafi <30203062+kasiafi@users.noreply.github.com>
findepi
reviewed
Mar 12, 2024
| sortKeyChannelForEndComparison = Optional.of(source.getLayout().get(frame.getSortKeyCoercedForFrameEndComparison().get())); | ||
| } | ||
| if (node.getOrderingScheme().isPresent()) { | ||
| sortKeyChannel = Optional.of(sortChannels.get(0)); |
Member
There was a problem hiding this comment.
sortChannels is a list. why using the first element only is sufficient?
or is the list known to be single element in this branch?
Member
Author
There was a problem hiding this comment.
sortKeyChannel and ordering are only used for window frame using RANGE PRECEDING or RANGE FOLLOWING. With such frame definition, a single sort item is required per spec, and it is guaranteed by the Analyzer.
Member
There was a problem hiding this comment.
then the code should use getOnlyElement(sortChannels)
Member
Author
There was a problem hiding this comment.
That wouldn't work. In general, we can have multiple sort channels at this point. But for frame type RANGE, there is only one. We capture it here and use later only for RANGE frames.
I added a clarifying comment: #24157.
Member
There was a problem hiding this comment.
What if it has multiple sortkeyChannel for frame type RANGE - Would we skip them ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.